ZeroMQ/cppzmq Migration to Modern API #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated cppzmq headers to latest version from GitHub - Migrated all setsockopt() calls to new set() API with zmq::sockopt - Updated 19 occurrences across 2 files: * src/arqnet/sn_network.cpp (18 occurrences) * src/rpc/zmq_server.cpp (1 occurrence) - Maintained backward compatibility with ZMQ_IDENTITY for older ZeroMQ versions - All ZeroMQ/cppzmq warnings eliminated (37 -> 0) - Added compatibility verification documentation - Build successful with 0 warnings
…pzmq - Deleted `WERYFIKACJA_KOMPATYBILNOSCI_ZMQ.md` and `PODSUMOWANIE_OSTRZEZEN.md` files as they are no longer needed. - These documents contained outdated information regarding ZeroMQ compatibility and compilation warnings.
- Added compatibility for OpenSSL 3.0+ by introducing modern API calls for EC key generation and RSA key assignment. - Included necessary headers for EC support and updated existing structures to manage EC keys. - Ensured backward compatibility with OpenSSL 1.1.1 by providing fallback implementations. - Improved error handling and logging for key generation processes.
- Deleted the OpenSSL migration report as it is no longer needed. - Cleaned up `net_ssl.cpp` by removing unused includes and unnecessary conditional compilation for deprecated EC key management. - Streamlined RSA key assignment logic to focus on the current OpenSSL version without legacy checks. - Improved code clarity and maintainability by eliminating outdated structures and comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZeroMQ/cppzmq Migration to Modern API
Summary
This PR migrates the project from deprecated ZeroMQ/cppzmq API to the modern
set()API withzmq::sockopt, eliminating all ZeroMQ-related compiler warnings while maintaining full backward compatibility.Changes
Code Migration
setsockopt()to modernset()API:src/arqnet/sn_network.cpp- 18 occurrencessrc/rpc/zmq_server.cpp- 1 occurrenceZMQ_VERSIONchecksDocumentation
ZEROMQ_MIGRATION_REPORT.md)Results
✅ Zero compilation errors
✅ Zero ZeroMQ/cppzmq warnings (reduced from 37)
✅ Backward compatibility maintained (malbit style preserved)
✅ All binaries built successfully
✅ Compatible with Ubuntu 24.04 and macOS system packages
Compatibility
external/cppzmq/for consistent APITesting
Files Changed
external/cppzmq/zmq.hpp- Updated to latest versionexternal/cppzmq/zmq_addon.hpp- Updated to latest versionsrc/arqnet/sn_network.cpp- Migrated to new API (18 calls)src/rpc/zmq_server.cpp- Migrated to new API (1 call)README.md- Updated with platform-specific versionsZEROMQ_MIGRATION_REPORT.md- Comprehensive migration documentationReview Checklist
Please review:
Related
This migration addresses deprecation warnings from cppzmq 4.7.0+ and ensures compatibility with system ZeroMQ packages on Ubuntu 24.04 and macOS.